Add developer build mode to GitHub action build-element-call.yaml #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkwp
added
the
PR-Developer-Experience
fkwp
changed the title
robintown
reviewed
Jun 9, 2025
package.json
Outdated
| @@ -8,7 +8,11 @@ | |||
| "dev:embedded": "vite --config vite-embedded.config.js", | |||
| "build": "yarn build:full", | |||
| "build:full": "NODE_OPTIONS=--max-old-space-size=16384 vite build", | |||
| "build:full:production": "yarn build:full", | |||
| "build:full:development": "NODE_OPTIONS=--max-old-space-size=16384 NODE_ENV=development vite build --mode development", | |||
There was a problem hiding this comment.
Suggested change
| "build:full:development": "NODE_OPTIONS=--max-old-space-size=16384 NODE_ENV=development vite build --mode development", | |
| "build:full:development": "yarn build:full --mode development", |
package.json
Outdated
| "build:embedded": "yarn build:full --config vite-embedded.config.js", | ||
| "build:embedded:production": "yarn build:embedded", | ||
| "build:embedded:development": "NODE_ENV=development yarn build:full --config vite-embedded.config.js --mode development", |
There was a problem hiding this comment.
Suggested change
| "build:embedded:development": "NODE_ENV=development yarn build:full --config vite-embedded.config.js --mode development", | |
| "build:embedded:development": "yarn build:full --mode development", |
There was a problem hiding this comment.
do you mean "build:embedded:development": "yarn build:embedded --mode development" ?
There was a problem hiding this comment.
is NODE_DEV=development not needed ?
… embedded build into one step
robintown
approved these changes
Jun 11, 2025
|
Super nice this is merged!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to enable the developer build mode for a specific PR by using the label "development build".
Using the developer build mode does:
NODE_ENV=development--mode developmentcommand line parameter toyarn(respectivelyvite)minifyoption invite.config.jsis set tofalse