Skip to content

fix: Force the docker image for lk-jwt-service to be pulled everytime #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented Jun 10, 2025

No description provided.

@fkwp fkwp requested a review from a team as a code owner June 10, 2025 08:44
@fkwp fkwp requested a review from BillCarsonFr June 10, 2025 08:44
@fkwp fkwp added the PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. label Jun 10, 2025
@@ -3,7 +3,7 @@ networks:

services:
auth-service:
image: ghcr.io/element-hq/lk-jwt-service:latest-ci
image: ghcr.io/element-hq/lk-jwt-service:0.2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if instead we should put pull_policy: always for the dev compose file. I though there was a way to specify a minumum version but lools like not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine from the EC dev PoV to rely on the latest stable lk-jwt-service. If you need a dev version of the lk-jwt-service you can do so by:

  • running your dev version of lk-jwt-service locally with LIVEKIT_INSECURE_SKIP_VERIFY_TLS="YES_I_KNOW_WHAT_I_AM_DOING" LIVEKIT_URL="wss://matrix-rtc.m.localhost/livekit/sfu" LIVEKIT_KEY=devkey LIVEKIT_SECRET=secret LIVEKIT_JWT_PORT=6080 LIVEKIT_LOCAL_HOMESERVERS=synapse.localhost ./lk-jwt-service
  • docker-compose -f ./dev-backend-docker-compose.yml up nginx synapse redis livekit, i.e., starting all services BUT the lk-jwt service

Note the backend/dev_nginx.conf is automatically using host.docker.internal:6080, i.e., running the local dev version.

   43  # MatrixRTC reverse proxy
   44  # - MatrixRTC Authorization Service
   45  # - LiveKit SFU websocket signaling connection
   46  upstream jwt-auth-services {
   47      server auth-server:6080;
   48      server host.docker.internal:6080;
   49  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by 80ebfca

@fkwp fkwp requested a review from BillCarsonFr June 10, 2025 10:16
@fkwp fkwp changed the title fix docker image for lk-jwt-service to 0.2.3 fix: Force the docker image for lk-jwt-service to be pulled everytime Jun 12, 2025
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we coudl do it for livekit and synapse too?

@fkwp fkwp merged commit 32b6250 into livekit Jun 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants