Added a failing test for indenting maps with sting as keys #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It assumes the following indentation to be correct:
```elixir
%{
"data" => %{
"foo" => %{
"bar" => nil
}
}
}
```
|
Great job @gausby! |
|
@whatyouhide it's not that big of a task ;) The hardest part is to find where in the file to put it. Perhaps we should do a restructure of the indentation tests at some point. |
|
@gausby yeah, indentation needs so much work. Everything helps IMO, so if you feel like it go for it 👍 :) |
|
@tonini ping? |
|
Sorry I had to talk to with the emacs evm guy because there where an issue with the binary. Thanks :) |
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
* silence warning * silence warning * handle eex compiler returning error colum * update elixir_sense * fix warning the test was incomplete * capture log * fix mixfile purging in in_fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It assumes the following indentation to be correct:
This relates to #359