No longer provide a feature in test-helper.el #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file isn't a library intended to be loaded with `require`. Instead `ert-runner` loads it using `load`. Other packages that use `ert-runner` also come with a file named test-helper.el and unfortunately many of those also provide `test-helper`, which leads to conflicts. Fixes #390.
|
Friendly ping! |
|
@tarsius Es duet mir huere leid das ig so lang nid gantwortert ha, bi grad chli usbalanciert im läbe. :-) |
|
Isch kei Problem. I hof skunnt alles widr ins Lot und s git sichr wichtigrs als söttig Prs. |
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
* Purge consolidated protocols before compilation Fixes elixir-editors#395 * move to dialyzer_test.exs * add comments * warn if ls fails
J3RN
pushed a commit
to J3RN/emacs-elixir
that referenced
this pull request
Apr 24, 2021
* Purge consolidated protocols before compilation Fixes elixir-editors#395 * move to dialyzer_test.exs * dialyzer_enabled? is already asserted at call site * add argument type assertions * return invalid_param when handling a request involving not open uri * add tests for text synchronization fixes some issues when certain sequence of notifications would create nil entries in source_files map * warn when cancelling unknown request * fix difference in watched extensions * add tests to workspace/didChangeWatchedFiles fix some consistency issues: dirty? flag not updated when file modified outside (no didSave) rebuild not triggered when opened dirty file modified outside * add tests for SourceFile.apply_content_changes based on https://github.com/microsoft/vscode-languageserver-node fixes a few edge cases when dealing with invalid ranges * add test * add utf test * add test fix full_range invalid when last line with unicode * fix apply_content_changes not preserving windows line endings * wip * do not warn if consolidation path does not exist * fix tests * return invalid_request * handle invalid uri in async requests * return invalid_request for not matched commands * handle client request errors * run formatter * rename * Refactor implementation of SourceFile.lines_with_endings The previous implementation did not have any bugs (that I saw), but I did find it more difficult to read and understand. I expect performance to be comparable. For more comprehensive testing I have added StreamData which adds property-based testing. We can probably use that in other portions of the code base as well. * Update apps/language_server/test/source_file_test.exs Co-authored-by: Jason Axelson <[email protected]> * run formatter * add disclaimer * combine lines_with_endings test cases Co-authored-by: Jason Axelson <[email protected]> Co-authored-by: Jason Axelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file isn't a library intended to be loaded with
require.Instead
ert-runnerloads it usingload. Other packages thatuse
ert-runneralso come with a file named test-helper.el andunfortunately many of those also provide
test-helper, whichleads to conflicts.
Fixes #390.