Skip to content

Locate closest .formatter.exs from the file formatted on save #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

nicocharlery
Copy link
Contributor

An umbrella app can have the following file tree:

${PROJECT_ROOT}/.formatter.exs
${PROJECT_ROOT}/apps/app1/.formatter.exs

In the case we run the elixir-format command in an elixir file located under the app1 application, the formatter used should be the one from app1, and not the one from the root.

The PR intends to give as default an example with the closest .formatter.exs instead of the project one, thanks to the emacs function locate-dominating-file.

@Trevoke
Copy link
Contributor

Trevoke commented Jun 3, 2018

Ooh, I really like that, thank you!

@Trevoke
Copy link
Contributor

Trevoke commented Jun 3, 2018

I love the idea of now having anything in the readme that depends on another package, and that gets us one step closer. Thank you! Now to find out how to remove the (projectile-project-p)...

@Trevoke Trevoke merged commit 028fe6c into elixir-editors:master Jun 3, 2018
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
* Check tests for warnings

Code is based on this blog post:
https://dashbit.co/blog/tests-with-warnings-as-errors

* Don't check unused deps on unsupported versions

Also only use `--warnings-as-errors` on 1.11 where it is fully working

* Missed removing the unconditional check-unused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants