Skip to content

fix: fontify defguard and defguardp #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

victorolinasc
Copy link
Contributor

defguard and defguardp were not being properly fontified. They were included in Elixir 1.7.

My setup:

  • elixir-mode-version: 2.3.1
  • Emacs version: 26.1
  • Fedora 28 amd64:
-> uname -a
Linux 4.17.19-200.fc28.x86_64 #1 SMP Fri Aug 24 15:47:41 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Those were included on Elixir 1.7 and were not being fontified.
@victorolinasc
Copy link
Contributor Author

I did not add a failing test as the change is only to add 2 words. If you want me to close this and open a PR with tests that fail I can do that too.

@Trevoke Trevoke merged commit ad06579 into elixir-editors:master Jan 3, 2019
@victorolinasc victorolinasc deleted the fix/fontify-defguard-and-defguardp branch January 3, 2019 17:39
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
tests added
fix %{optional(atom)=>any} being translated to %{} - should be map
do not translate %Struct{} to Struct.t if Struct.t does not exist
added tweaks for fun(), list() and struct()
Fixes elixir-editors#425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants