Skip to content

feat: switch CI and build system #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

victorolinasc
Copy link
Contributor

This is the much delayed swith from travis + Cask + ert-runner to Eldev.

Sorry for the loooooooong delay on this... will try to be more present here :)

It should fix all the issues raised on #466 and some others.

Example run: https://github.com/victorolinasc/emacs-elixir/actions/runs/671131814

@victorolinasc victorolinasc self-assigned this Mar 20, 2021
(eldev-use-package-archive 'melpa)

(eldev-use-plugin 'autoloads)
(eldev-use-plugin 'undercover)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to send statistics to coveralls or something with this. Related docs: https://github.com/doublep/eldev#undercover-plugin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. That can probably be handled in a new PR.

@@ -11,7 +11,7 @@
;; Created: Mon Nov 7 2011
;; Keywords: languages elixir
;; Version: 2.4.0
;; Package-Requires: ((emacs "24") (pkg-info "0.4"))
;; Package-Requires: ((emacs "25") (pkg-info "0.6"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in other discussions, I've bumped from 24 to 25.

Copy link
Contributor

@jsmestad jsmestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ❤️! I retried the tests just to double-check how reliable they are.

(eldev-use-package-archive 'melpa)

(eldev-use-plugin 'autoloads)
(eldev-use-plugin 'undercover)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. That can probably be handled in a new PR.

@axelson axelson merged commit 4745cac into elixir-editors:master Mar 20, 2021
@victorolinasc victorolinasc deleted the feat/new_build_system branch March 20, 2021 20:14
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants