Skip to content

chore: update guides with new build system #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

victorolinasc
Copy link
Contributor

Updated README and CONTRIBUTING with the new build system and setup.

I took some liberties and will happily change if it seems not good.

  1. Removed EVM instructions
  2. Removed el-get installation instructions

1 is because I think most people don't use it outside CI systems anyway. I may be wrong though. Perhaps a docker setup to run tests in a pristine Emacs would be better here but I haven't set all that up yet.

2 is because it seemed weird to have el-get there without other alternatives. I thought that we should leave only default installation instructions and not custom ones. If we were to add custom ones than we should at least provide a few other options.

@victorolinasc victorolinasc requested a review from axelson March 20, 2021 20:36
@victorolinasc victorolinasc self-assigned this Mar 20, 2021
Copy link
Contributor

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@axelson axelson merged commit d8c29c7 into elixir-editors:master Mar 22, 2021
@victorolinasc victorolinasc deleted the chore/update_readme_and_contributing branch March 23, 2021 00:51
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants