Skip to content

Backport ppss accessors, use setq-local & more #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2021

Conversation

sirikid
Copy link
Contributor

@sirikid sirikid commented May 7, 2021

  1. Backport ppss accessors from Emacs 27
  2. Use setq-local instead of set and make-local-variable
  3. Easy documentation fixes
  4. Remove s from test-helper, it's unused

@sirikid sirikid force-pushed the feature/setq-local branch from 9afca08 to bbe0e27 Compare May 7, 2021 07:41
Copy link
Contributor

@jsmestad jsmestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

Copy link
Contributor

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a brief look and it looks good to me too 👍

@axelson axelson merged commit 6bbc1e5 into elixir-editors:master May 9, 2021
@sirikid
Copy link
Contributor Author

sirikid commented May 10, 2021

Cool, thanks. The next stage of CI is melpa users :^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants