Remove more checks that can now be performed by the type system

Author: josevalim

lib/elixir/src/elixir_expand.erl

@@ -452,7 +452,6 @@ expand({{'.', DotMeta, [Left, Right]}, Meta, Args}, S, E)
 expand({{'.', DotMeta, [Expr]}, Meta, Args}, S, E) when is_list(Args) ->
   assert_no_match_or_guard_scope(Meta, "anonymous call", S, E),
   {[EExpr | EArgs], SA, EA} = expand_args([Expr | Args], S, E),
-  is_atom(EExpr) andalso function_error(Meta, E, ?MODULE, {invalid_function_call, EExpr}),
   {{{'.', DotMeta, [EExpr]}, Meta, EArgs}, SA, EA};
 
 %% Invalid calls
@@ -887,7 +886,6 @@ expand_remote(Receiver, DotMeta, Right, Meta, Args, S, SL, #{context := Context}
 
       case rewrite(Context, Receiver, DotMeta, Right, AttachedMeta, EArgs, S) of
         {ok, Rewritten} ->
-          maybe_warn_comparison(Rewritten, Args, E),
           {Rewritten, elixir_env:close_write(SA, S), EA};
 
         {error, Error} ->
@@ -914,32 +912,6 @@ rewrite(guard, Receiver, DotMeta, Right, Meta, EArgs, S) ->
 rewrite(_, Receiver, DotMeta, Right, Meta, EArgs, _S) ->
   {ok, elixir_rewrite:rewrite(Receiver, DotMeta, Right, Meta, EArgs)}.
 
-maybe_warn_comparison({{'.', _, [erlang, Op]}, Meta, [ELeft, ERight]}, [Left, Right], E)
-    when Op =:= '>'; Op =:= '<'; Op =:= '=<'; Op =:= '>='; Op =:= min; Op =:= max ->
-
-    case is_nested_comparison(Op, ELeft, ERight, Left, Right) of
-      false -> ok;
-      CompExpr ->
-        elixir_errors:file_warn(Meta, E, ?MODULE, {nested_comparison, CompExpr})
-    end;
-maybe_warn_comparison(_, _, _) ->
-  ok.
-
-is_nested_comparison(Op, ELeft, ERight, Left, Right) ->
-  NestedExpr = {elixir_utils:erlang_comparison_op_to_elixir(Op), [], [Left, Right]},
-  case is_comparison_expression(ELeft) of
-    true ->
-      NestedExpr;
-    false ->
-      case is_comparison_expression(ERight) of
-        true -> NestedExpr;
-        false -> false
-      end
-  end.
-is_comparison_expression({{'.',_,[erlang, Op]},_,_})
-  when Op =:= '>'; Op =:= '<'; Op =:= '=<'; Op =:= '>=' -> true;
-is_comparison_expression(_Other) -> false.
-
 %% Lexical helpers
 
 expand_opts(Meta, Kind, Allowed, Opts, S, E) ->
@@ -1241,8 +1213,6 @@ format_error({invalid_clauses, Name}) ->
     "the function \"~ts\" cannot handle clauses with the -> operator because it is not a macro. "
     "Please make sure you are invoking the proper name and that it is a macro",
   io_lib:format(Message, [Name]);
-format_error({invalid_function_call, Expr}) ->
-  io_lib:format("invalid function call :~ts.()", [Expr]);
 format_error({invalid_call, Call}) ->
   io_lib:format("invalid call ~ts", ['Elixir.Macro':to_string(Call)]);
 format_error({invalid_quoted_expr, Expr}) ->

lib/elixir/test/elixir/kernel/expansion_test.exs

@@ -654,12 +654,6 @@ defmodule Kernel.ExpansionTest do
     test "expands base and args" do
       assert expand(quote(do: a.(b))) == quote(do: a().(b()))
     end
-
-    test "raises on atom base" do
-      assert_compile_error(~r"invalid function call :foo.()", fn ->
-        expand(quote(do: :foo.(a)))
-      end)
-    end
   end
 
   describe "remotes" do

lib/elixir/test/elixir/kernel/warning_test.exs

@@ -2147,29 +2147,6 @@ defmodule Kernel.WarningTest do
     purge(Sample)
   end
 
-  test "nested comparison operators" do
-    message =
-      capture_compile("""
-       1 < 3 < 5
-      """)
-
-    assert message =~ "nofile:1:8\n"
-    assert message =~ "Elixir does not support nested comparisons"
-    assert message =~ "1 < 3 < 5"
-
-    message =
-      capture_compile("""
-        x = 5
-        y = 7
-        1 < x < y < 10
-      """)
-
-    assert message =~ "Elixir does not support nested comparisons"
-    assert message =~ "1 < x < y < 10"
-    assert message =~ "nofile:3:9\n"
-    assert message =~ "nofile:3:13\n"
-  end
-
   test "def warns if only clause is else" do
     assert_warn_compile(
       ["nofile:2:7\n", "\"else\" shouldn't be used as the only clause in \"def\""],