Fix bug with edge-case when converting to algebra quoted Elixir alias #11572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code would crash:
iex> Code.quoted_to_algebra(Elixir)
** (MatchError) no match of right hand side value: "Elixir"
(elixir 1.13.1) lib/code/normalizer.ex:254: Code.Normalizer.normalize_literal/3
(elixir 1.13.1) lib/code.ex:1107: Code.quoted_to_algebra/2
Therefore, this as well:
iex> Macro.to_string(Elixir)
** (MatchError) no match of right hand side value: "Elixir"
(elixir 1.13.1) lib/code/normalizer.ex:254: Code.Normalizer.normalize_literal/3
(elixir 1.13.1) lib/code.ex:1107: Code.quoted_to_algebra/2
(elixir 1.13.1) lib/macro.ex:948: Macro.to_string/1
eksperimental
force-pushed
the
macro_string
branch
from
73e0207 to
63be03a
Compare
whatyouhide
approved these changes
Jan 16, 2022
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jan 16, 2022
…#11572) The following code would crash: iex> Code.quoted_to_algebra(Elixir) ** (MatchError) no match of right hand side value: "Elixir" (elixir 1.13.1) lib/code/normalizer.ex:254: Code.Normalizer.normalize_literal/3 (elixir 1.13.1) lib/code.ex:1107: Code.quoted_to_algebra/2 Therefore, this as well: iex> Macro.to_string(Elixir) ** (MatchError) no match of right hand side value: "Elixir" (elixir 1.13.1) lib/code/normalizer.ex:254: Code.Normalizer.normalize_literal/3 (elixir 1.13.1) lib/code.ex:1107: Code.quoted_to_algebra/2 (elixir 1.13.1) lib/macro.ex:948: Macro.to_string/1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code would crash:
Therefore, this as well: