Add ExUnit.run/1 to rerun test modules #11788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kw7oe
commented
May 1, 2022
josevalim
reviewed
May 1, 2022
josevalim
reviewed
May 1, 2022
- Register `:ex_unit_async` module attributes as persisted attributes to allow us to the info through `Module.__info__(:attributes)` callback. - This in turn allow us to add provided modules as sync/async conditionally.
kw7oe
commented
May 1, 2022
| Returns a map containing the total number of tests, the number | ||
| of failures, the number of excluded tests and the number of skipped tests. | ||
| """ | ||
| @spec run() :: suite_result() | ||
| def run do | ||
| @spec run(list(atom)) :: suite_result() |
There was a problem hiding this comment.
Since the spec change, do we need to add the since attribute?
There was a problem hiding this comment.
Good question but I don't think so! We can mention this difference in the docs. :)
josevalim
reviewed
May 1, 2022
josevalim
changed the title
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
ExUnit.rerun/1to rerun tests given a list of test modules.Context
Often times, when writing a tutorial in Livebook, I want to write a test case for
the users so they could interactively write some code to make it pass. This is especially
helpful when we use Livebook as a teaching medium.
Currently, there are no ways to support ruruning a test without rewriting it.
Proposed solution
Add
ExUnit.rerun/1to take in a list of test modules to be rerun:For more, refer to the proposal in the mailing list