Make Logger.Formatter an official formatter for Erlang logger #12400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
reviewed
Apr 22, 2025
| if handler = Application.get_env(:logger, :default_handler, default_handler) do | ||
| config = | ||
| handler | ||
| |> Keyword.put_new(:filters, remote_gl: {&:logger_filters.remote_gl/2, :stop}) |
There was a problem hiding this comment.
Curious,
Is this filter here so that the log message isn't both logged in the originating node and the remote GL node?
So, if I understand correctly, with this filter in place, it is only logged in the remote GL node and stopped in the originating node, right?
There was a problem hiding this comment.
Sorry, just a bit confused with the comment in the documentation
elixir/lib/logger/lib/logger.ex
Lines 239 to 240 in e34495e
Just to be sure it is precise to say
# Do not log messages from other nodes
or something more like...
# Do not log messages that are going to be logged in a remote node
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP, I need to work on the docs and clean up some other APIs.