Skip to content

Use the cd option in Mix.Shell #12410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023
+7 −9
Merged

Use the cd option in Mix.Shell #12410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions lib/mix/lib/mix/tasks/deps.compile.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,16 +304,14 @@ defmodule Mix.Tasks.Deps.Compile do
defp do_command(dep, config, command, print_app?, env \\ []) do
%Mix.Dep{app: app, system_env: system_env, opts: opts} = dep

File.cd!(opts[:dest], fn ->
env = [{"ERL_LIBS", Path.join(config[:env_path], "lib")} | system_env] ++ env
env = [{"ERL_LIBS", Path.join(config[:env_path], "lib")} | system_env] ++ env

if Mix.shell().cmd(command, env: env, print_app: print_app?) != 0 do
Mix.raise(
"Could not compile dependency #{inspect(app)}, \"#{command}\" command failed. " <>
deps_compile_feedback(app)
)
end
end)
if Mix.shell().cmd(command, env: env, print_app: print_app?, cd: opts[:dest]) != 0 do
Mix.raise(
"Could not compile dependency #{inspect(app)}, \"#{command}\" command failed. " <>
deps_compile_feedback(app)
)
end

true
end
Expand Down