Formatter keeps quotes in atom keys #13108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 15, 2023
| else | ||
| IO.iodata_to_binary([?", Atom.to_string(atom), ?", ?:]) | ||
| [?", atom |> Atom.to_string() |> String.replace("\"", "\\\""), ?", ?:] |
There was a problem hiding this comment.
I think we should use Macro.inspect_atom(:key, atom). This way we can even skip the Macro.classify_atom call.
There was a problem hiding this comment.
Oh that's a nice one, totally forgot about inspect_atom!
But it seems to be over-escaping backslashes for our usage:
Will try to figure out if we can remove the double escape.
There was a problem hiding this comment.
Also noticed that this code here is almost the same, there's probably a way to refactor it (maybe with Macro.inspect_atom/2)
There was a problem hiding this comment.
Ah, it is because strings in the formatter are already unescaped. My bad. Your PR is good to go!
josevalim
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13103