Skip to content

Update docs for mix test --slowest and --slowest-modules #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerPachal
Copy link
Contributor

@TylerPachal TylerPachal commented Sep 27, 2024

I was hunting down a slow test and wasn't sure if --slowest and --slowest-modules considered time spent in setup and setup_all.

After some testing, I found that they both count time spent in setup and neither counts the time spent in setup_all.

Maybe this is obvious to other people, but it wasn't to me, and might be worth adding to the documentation.


Here are the updated docs:

image

@josevalim josevalim merged commit d127196 into elixir-lang:main Sep 27, 2024
@josevalim
Copy link
Member

Merged this as it is correct as of now but we should probably include the time of setup_all in --slowest-modules.

@TylerPachal TylerPachal deleted the mix-test-slowest-update-docs branch September 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants