mention alternatives to compare/2 for comparison in other dates and times #14151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #14147
During our upgrade to Elixir 1.18 we got some compile warnings about the usage of
==
onDateTime
structs. https://hexdocs.pm/elixir/1.18.1/DateTime.html suggested usingcompare/2
which led to replacingwith
However, a far better solution is:
elixir
if DateTime.after?(user.password_reset_token_sent_at, oldest_allowed_token_datetime) do