Skip to content

Show hints when run mix test --no-color #14198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

NickNeck
Copy link
Contributor

The hint for :equivalent_but_different_strings is not shown when you run mix test --no-color.

This PR fixes it by running find_diff regardless of whether the diff_formatter is enabled. The returned hints are always kept and the formatted result is set to nil if the diff_formatter is not enabled.

@josevalim josevalim merged commit 6613193 into elixir-lang:main Jan 18, 2025
8 of 9 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants