-
Notifications
You must be signed in to change notification settings - Fork 343
More accurate autolink warnings line #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mix.exs
Outdated
# TODO | ||
{:earmark_parser, "~> 1.4.31", | ||
github: "wojtekmach/earmark_parser", branch: "wm-codespan-line"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I saw your other PRs regarding warnings I was hoping the change in this PR was coming soon :) looks great! Now we just need the various LSPs to warn for this as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely beautiful.
df5c958
to
cebdf5f
Compare
Do you know of any way to fix this for Erlang as well?
as the stacktrace, instead of something that it can convert to a nice warning message. |
Elixir allows you to compile code outside of modules, but it does so by compiling the code inside a fake module with a fake Before printing stacktraces, Elixir explicitly matches on the |
I managed to get a bit further by setting
Still need to figure out how to get the code snippet printed, or is that something that mix does? |
printing snippet is an Elixir 1.16 feature! |
Aha! |
with an upgraded Elixir it works great for regular links. Custom links don't have the line number info though so they look a bit odd :) Looking forward to the same info being added about I'll submit a PR with the changes I had to do to make Erlang work. |
Demo: