Move action links out from heading tags #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! :) Thank you! |
|
Annotation-related ordering and alignment needs bringing into line. I'll update that and the tests soon. |
Avoids action link text being read out as part of "navigated to..." announcements. elixir-lang#1987
DavidOliver
force-pushed
the
heading-accessibility-1
branch
from
57c9b4e to
19e9d9b
Compare
|
Function annotations now re-aligned and tests updated. Headings now use Flexbox rather than floats, and respond better to narrow viewports:
|
|
Closing and reopening for CI. |
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12647009919/artifacts/2394209851 |
josevalim
reviewed
Jan 7, 2025
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angelikatyborska, @josevalim,
This draft PR only updates the headings which contain action links:
Headings which contain hover links are not changed here; the hover links do not include text so I believe "Navigated to ..." announcements are okay, and changing these headings would require some more styling updates. If it needs to be done I can look at doing so, but I thought I'd get you to take a look before spending more time on it.
@angelikatyborska, if you could take another look, that would be great.
Still to do:
I'll wait to hear back.
Avoids action link text being read out as part of "navigated to..." announcements.
#1987