Refactor transitions for consistency across styles #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12844284546/artifacts/2450954348 |
…moother interactions
|
@hichemfantar if you mouse over the root items in the sidebar, there is a small jiggle now. Is that intentional? I am afraid part of it is because we are using |
|
I fixed the bug you talked about and introduces multiple presets |
josevalim
reviewed
Jan 18, 2025
assets/css/custom-props/common.css
Outdated
Comment on lines
82
to
104
| .transition-all { | ||
| transition: var(--transition-all); | ||
| } | ||
|
|
||
| .transition-colors { | ||
| transition: var(--transition-colors); | ||
| } | ||
|
|
||
| .transition-opacity { | ||
| transition: var(--transition-opacity); | ||
| } | ||
|
|
||
| .transition-shadow { | ||
| transition: var(--transition-shadow); | ||
| } | ||
|
|
||
| .transition-transform { | ||
| transition: var(--transition-transform); | ||
| } | ||
|
|
||
| .transition-none { | ||
| transition-property: none; | ||
| } |
There was a problem hiding this comment.
Do we need the classes? We don't use them anywhere for now, right? So we can skip them and add them later if necessary. :)
josevalim
reviewed
Jan 18, 2025
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize transition properties by introducing a common variable, ensuring uniformity in animation effects throughout the styles.
Screen.Recording.2025-01-17.at.6.58.29.PM.mp4
Screen.Recording.2025-01-17.at.6.35.41.PM.mp4