Skip to content

Go to latest with path if exists #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

alisinabh
Copy link
Contributor

@alisinabh alisinabh commented Jan 18, 2025

Base on this comment from @wojtekmach (thank you), this PR adds redirect to exact page user currently is visiting in case it exists in the latest version.

P.S sorry for the delay. I was unwell for the past week.

Copy link

github-actions bot commented Jan 18, 2025

@alisinabh alisinabh force-pushed the go-to-latest-with-path branch from e89cb58 to 796ed3b Compare January 18, 2025 09:12
@alisinabh alisinabh force-pushed the go-to-latest-with-path branch from 796ed3b to 5a4e84e Compare January 18, 2025 09:13
@josevalim josevalim merged commit 194119f into elixir-lang:main Jan 18, 2025
4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@clicktodev
Copy link
Contributor

this code in now breaking for some reason, and it's breaking many other things along with it like the settings dialog
versionsGoToLatest.addEventListener("click", handleGoToLatestClicked);

Uncaught TypeError: Cannot read properties of null (reading 'addEventListener')

@josevalim
Copy link
Member

Ah, this needs to be done conditionally, as the version button won't be always there. I will push a fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants