Skip to content

Bring in work from head fork #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 17, 2018
Merged

Conversation

Trevoke
Copy link
Member

@Trevoke Trevoke commented Jul 17, 2018

No description provided.

znorris and others added 18 commits July 2, 2018 19:06
Fixes incorrect dialyzer warning. Resolves #85
Disable custom logger backend on Elixir 1.7.0-dev due to incompatibility
The big difference for Dialyzer with OTP 21 is that the Dbgi chunk is required, so we check for that. If core Elixir files don't contain it, we show an error and don't run Dialyzer.

Also handle `Mix.Utils.last_modified/1` returning posix time instead of `:calendar.universal_time()` type
…eam/1

Under the hood, this function can take either a charlist with the file path or the file's contents as a binary. However, if it fails (due to no debug_info chunk, for example), it will crash when the argument is the file's contents instead of path. Unfortunately, changing this means we do extraneous file reads from disk, but it's worth it for reliability.
Path file path instead of contents to :dialyzer_utils.get_core_from_b…
@Trevoke Trevoke changed the title Bring in work from head branch Bring in work from head fork Jul 17, 2018
@Trevoke Trevoke merged commit b7b5e9b into elixir-lsp:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants