Improve test reliability #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tags to allow running only some of the tests
- `mix test --only fixture` to run only the tests that use our custom
in_fixture helper
- `mix test --exclude slow` to exclude extra slow tests (primarily dialyzer)
- Fix a race-condition that showed up in some debugger tests
- Without this fix (which admittedly is hacky) the "notifies about
process exit" debugger test would fail about 1/4 of the time.
- Capture output and logs from debugger tests
- Otherwise that output would make it more difficult to read the test output
- Rename the error raised in debugger tests to make it more obvious that
these are test-specific errors and not a generic ArgumentError (which
could be raised for multiple reasons)
Intent is to fix this test error:
1) test put_chars mfa mfa binary (ElixirLS.Utils.OutputDeviceTest)
Error: test/output_device_test.exs:175
** (MatchError) no match of right hand side value: {:error, {:already_started, #PID<0.484.0>}}
stacktrace:
test/output_device_test.exs:72: ElixirLS.Utils.OutputDeviceTest.__ex_unit_setup_0/1
test/output_device_test.exs:1: ElixirLS.Utils.OutputDeviceTest.__ex_unit__/2
https://github.com/elixir-lsp/elixir-ls/pull/488/checks?check_run_id=1899187694
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tags to allow running only some of the tests
mix test --only fixtureto run only the tests that use our customin_fixture helper
mix test --exclude slowto exclude extra slow tests (primarily dialyzer)