-
Notifications
You must be signed in to change notification settings - Fork 216
Improvements to document outline #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apps/language_server/lib/language_server/providers/document_symbols.ex
Outdated
Show resolved
Hide resolved
It looks like code in this PR triggered an inconsistency in elixir formatter as it reports not formatted on < 1.9 |
Hmmm, the diff is annoying:
One workaround is to use a binding. So something like:
That's perhaps a little uglier, but at least it is straightforward and semantically the same. Alternatively we could try to run the formatter check only 1.9.x, but I'm not sure how to do that with travis. |
As far as I know, there is Therefore doing something like this should work: script:
- MIX_ENV=test mix compile --force --warnings-as-errors
- [[ ${ELIXIR_VERSION} == 1.9* ]] && mix format --check-formatted
- mix test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR introduces many improvements and fixes to document outline provider.
describe
blocks (basing on https://github.com/kent-medin/elixir-ls/commit/14c892b4e96015345a537f68312abe1b92e1981e) which fixes Incorporate nested outline view #67 (and originally Add nested outline view JakeBecker/elixir-ls#188 and Outline doesn't seem to support describe blocks in test files JakeBecker/elixir-ls#178)setup
andsetup_al
l blocks