Skip to content

Extract impl name for textDocument/documentSymbol #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Extract impl name for textDocument/documentSymbol #79

merged 3 commits into from
Dec 7, 2019

Conversation

axelson
Copy link
Member

@axelson axelson commented Nov 27, 2019

Instead of only showing @impl for any @impl lines, show the name of the impl as well. So either @impl true or @impl MyApp.SomeBehaviour

Here is what it looks like VSCode's outline view:
vscode-outline-screenshot

end

# @impl BehaviourModule
defp extract_symbol(_current_module, {:@, _, [{:impl, location, [impl_expression]}]}) do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the same for @behaviour

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good idea! I've added that to the PR.

@axelson axelson merged commit a522df8 into elixir-lsp:master Dec 7, 2019
@axelson axelson deleted the extract-impl-name branch December 7, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants