Use metadata in Introspection.actual_mod_fun #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before it was . column for remote calls and column of fun name for local
asummers
reviewed
Nov 22, 2019
asummers
reviewed
Nov 22, 2019
asummers
reviewed
Nov 22, 2019
asummers
reviewed
Nov 22, 2019
msaraiva
approved these changes
Nov 26, 2019
axelson
added a commit
to elixir-lsp/elixir-ls
that referenced
this pull request
Dec 22, 2019
* Bump elixir_sense and use ElixirSense.references/3 Now that elixir-lsp/elixir_sense#42 is fixed (via elixir-lsp/elixir_sense#61) and umbrella support is added via elixir-lsp/elixir_sense#46 we no longer need to maintain a separate implementation of `ElixirSense.references/3` and can instead use the implementation provided by `ElixirSense`. This is good because now we're using less of the private internals of `ElixirSense`. * Map nil uri from ElixirSense to the current file * Upgrade elixir_sense after infinite loop * Handle types being an atom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes order of returned funs - now builtin types are tried after local functions. Previous implementation returned
{mod, fun}regardless if the function existed or not. Now metadata is used to verify that.While working on this i added a few tests and noticed that finding references for imported functions was not working. It turned out that
Source.subject_and_pos returnedwrong column for the call and there was some inconsistency in how call positions were stored in metadata.I also had to fix
ModuleInfo.get_module_funsas it was crashing when called for erlang modulesFixes #42
Resolves #43