Correct typespecs #177
Merged
Correct typespecs #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmwaffles
reviewed
Dec 2, 2021
warmwaffles
reviewed
Dec 2, 2021
lib/exqlite/sqlite3.ex
Outdated
| @@ -46,7 +46,7 @@ defmodule Exqlite.Sqlite3 do | |||
| case Sqlite3NIF.execute(conn, String.to_charlist(sql)) do | |||
| :ok -> :ok | |||
| {:error, reason} -> {:error, reason} | |||
| _ -> {:error, "unhandled error"} | |||
| # _ -> {:error, "unhandled error"} | |||
There was a problem hiding this comment.
Why was the fall through case commented out?
There was a problem hiding this comment.
The only possible returns from execute are covered.
warmwaffles
requested changes
Dec 2, 2021
|
Updated branch |
warmwaffles
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the typespecs, making it work with Dialyzer.
You can add Dialyzer to the project itself in
devandtestenvironments (but notprod) by adding this todeps():then run