Skip to content

Minor fixes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Minor fixes #11

merged 1 commit into from
Aug 25, 2023

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Aug 22, 2023

  • Fix checklist pruning
  • Fix adding a valid pair
  • Treat frozen and waiting pairs in the same way for now

@mickel8 mickel8 changed the base branch from master to update-example August 22, 2023 19:53
Base automatically changed from update-example to master August 23, 2023 08:09
@mickel8 mickel8 force-pushed the minor-fixes branch 6 times, most recently from d3fb22f to 69ce2a9 Compare August 25, 2023 07:11
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 76.74% and project coverage change: +0.10% 🎉

Comparison is base (193a38c) 77.90% compared to head (0d45302) 78.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   77.90%   78.00%   +0.10%     
==========================================
  Files          13       13              
  Lines         715      723       +8     
==========================================
+ Hits          557      564       +7     
- Misses        158      159       +1     
Files Changed Coverage Δ
lib/ice_agent.ex 77.56% <72.22%> (+0.15%) ⬆️
lib/checklist.ex 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickel8 mickel8 marked this pull request as ready for review August 25, 2023 09:33
@mickel8 mickel8 requested a review from LVala August 25, 2023 09:34
@LVala LVala merged commit 393849d into master Aug 25, 2023
@LVala LVala deleted the minor-fixes branch August 25, 2023 09:53
@mickel8 mickel8 mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants