Skip to content

Add basic keepalives #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add basic keepalives #12

merged 1 commit into from
Sep 1, 2023

Conversation

LVala
Copy link
Member

@LVala LVala commented Aug 25, 2023

Also, bump excoveralls version as it wouldn't compile on 0.14.x.

@LVala LVala self-assigned this Aug 25, 2023
@LVala
Copy link
Member Author

LVala commented Aug 25, 2023

TODO:

  • tests
  • way to configure timeouts

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 35.00% and project coverage change: -0.46% ⚠️

Comparison is base (393849d) 77.04% compared to head (ce3a8c4) 76.58%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   77.04%   76.58%   -0.46%     
==========================================
  Files          13       13              
  Lines         723      743      +20     
==========================================
+ Hits          557      569      +12     
- Misses        166      174       +8     
Files Changed Coverage Δ
lib/ice_agent.ex 75.41% <13.33%> (-1.21%) ⬇️
lib/candidate_pair.ex 100.00% <100.00%> (+12.50%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LVala LVala linked an issue Aug 25, 2023 that may be closed by this pull request
@LVala LVala marked this pull request as ready for review September 1, 2023 13:33
@LVala LVala requested a review from mickel8 September 1, 2023 13:33
@LVala LVala merged commit 6790fa2 into master Sep 1, 2023
@LVala LVala deleted the keepalives branch September 1, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keepalives
2 participants