Skip to content

Fix ICECandidate types #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix ICECandidate types #174

merged 1 commit into from
Nov 20, 2024

Conversation

roznawsk
Copy link
Contributor

Fix type defnitions to match the actual types

@roznawsk roznawsk requested a review from sgfn November 19, 2024 17:38
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (f13a6b4) to head (5a3fb74).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   87.89%   88.10%   +0.21%     
==========================================
  Files          47       47              
  Lines        2370     2370              
==========================================
+ Hits         2083     2088       +5     
+ Misses        287      282       -5     
Files with missing lines Coverage Δ
lib/ex_webrtc/ice_candidate.ex 0.00% <ø> (ø)
lib/ex_webrtc/peer_connection.ex 85.84% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13a6b4...5a3fb74. Read the comment docs.

---- 🚨 Try these New Features:

@roznawsk roznawsk merged commit 217519f into master Nov 20, 2024
3 checks passed
@roznawsk roznawsk deleted the fix-candidate-types branch November 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants