Skip to content

Pass all codecs instead of selected one to the rtp_receiver and rtp_sender #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Jan 30, 2025

This PR passes all codecs that were negotiated to the RTP sender and RTP receiver. Because in our case these codecs are always the same i.e. (transceiver.codecs==sender.codecs==receiver.codecs), they are not publicly exposed in RTPSender and RTPReceiver structs to not create confusion or suggest that they may differ.

The behavior of RTP sender and receiver remains the same i.e. they always pick the first codec and use it for sending or expect it when receiving RTP packets.

In the next PR, I am going to allow to set codec that should be used for sending.

@mickel8 mickel8 force-pushed the refactor branch 2 times, most recently from b4f7556 to 8160ace Compare January 30, 2025 11:40
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (f87341e) to head (60dd117).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   84.72%   84.67%   -0.05%     
==========================================
  Files          49       49              
  Lines        2507     2512       +5     
==========================================
+ Hits         2124     2127       +3     
- Misses        383      385       +2     
Files with missing lines Coverage Δ
lib/ex_webrtc/rtp_receiver.ex 78.04% <100.00%> (+1.12%) ⬆️
lib/ex_webrtc/rtp_sender.ex 93.40% <100.00%> (+0.54%) ⬆️
lib/ex_webrtc/rtp_transceiver.ex 90.36% <100.00%> (-0.40%) ⬇️
lib/ex_webrtc/utils.ex 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87341e...60dd117. Read the comment docs.

@mickel8 mickel8 merged commit 7f3b1bd into master Jan 30, 2025
3 checks passed
@mickel8 mickel8 deleted the refactor branch January 30, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants