Skip to content

Fix recorder overriding tracks instead of merging on add_tracks. Release 0.8.1 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

sgfn
Copy link
Member

@sgfn sgfn commented Feb 11, 2025

Fixes issue outlined in #194

The new tracks were correctly merged into state in line 169 but state was then erroneously updated again in line 180, causing the freshly added tracks to override the existing ones.

@sgfn sgfn requested a review from mickel8 February 11, 2025 14:33
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (12d9b04) to head (acae32b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/recorder.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   85.25%   85.13%   -0.12%     
==========================================
  Files          49       49              
  Lines        2584     2584              
==========================================
- Hits         2203     2200       -3     
- Misses        381      384       +3     
Files with missing lines Coverage Δ
lib/ex_webrtc/recorder.ex 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d9b04...acae32b. Read the comment docs.

@sgfn sgfn merged commit 4cebfd8 into master Feb 12, 2025
3 checks passed
@sgfn sgfn deleted the fix/recorder-not-merging-tracks branch February 12, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants