Skip to content

Accept padded DataChannelAck, fix closing DataChannel #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Mar 17, 2025

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.26%. Comparing base (26f929d) to head (b5b7801).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/sctp_transport.ex 0.00% 1 Missing ⚠️
lib/ex_webrtc/sctp_transport/dcep.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   88.29%   88.26%   -0.04%     
==========================================
  Files          49       49              
  Lines        2580     2581       +1     
==========================================
  Hits         2278     2278              
- Misses        302      303       +1     
Files with missing lines Coverage Δ
lib/ex_webrtc/sctp_transport.ex 83.23% <0.00%> (ø)
lib/ex_webrtc/sctp_transport/dcep.ex 66.66% <0.00%> (-2.30%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f929d...b5b7801. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mickel8 mickel8 changed the title Accept padded DataChannelOpenAck, fix closing DataChannel Accept padded DataChannelAck, fix closing DataChannel Mar 17, 2025
@mickel8 mickel8 merged commit b240306 into master Mar 17, 2025
3 checks passed
@mickel8 mickel8 deleted the datachannels branch March 17, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant