Skip to content

Add per-second stats, UX improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2024
Merged

Add per-second stats, UX improvements #5

merged 6 commits into from
Jul 11, 2024

Conversation

LVala
Copy link
Member

@LVala LVala commented Jul 9, 2024

No description provided.

@LVala LVala self-assigned this Jul 9, 2024
@LVala LVala marked this pull request as ready for review July 10, 2024 14:21
@LVala LVala requested a review from mickel8 July 10, 2024 14:21
@LVala LVala mentioned this pull request Jul 10, 2024
Open
63 tasks
mickel8
mickel8 reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great with one minor thing 👀

In WebRTC Internals we have bytes_sent_in_bits/s and I think we would like to follow this convetion

@LVala LVala requested a review from mickel8 July 11, 2024 08:51
@LVala LVala merged commit 40b67a6 into master Jul 11, 2024
@LVala LVala deleted the per_sec_stats branch July 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickel8 mickel8 mickel8 approved these changes

Assignees

@LVala LVala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LVala @mickel8