Fix RC between publishers with duplicated ids #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
changed the title
sgfn
requested changes
Mar 21, 2025
|
@sgfn I revisited how publisher is cleaned up. Could you test your edge cases and see if everything works correctly? |
|
@mickel8 sure I can, just be warned that this has the potential to further delay the demo At first glance, I'm worried that, after these changes, certain things will happen multiple times when they shouldn't... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen that the old live view is still alive when the new one is created - e.g. when a page refresh happens, the backend process is alive for over 10 seconds (maybe it's waiting for reconnects?).
This might result in two processes publishing on the same topic. This PR fixes this issues by introducing
lockedflag that is released when we stop getting tracks info from the old publisher or we get the bye message.Credits for the solution @brzep 👏