Add support for simulcast #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t as it resets without a form
…ams_info timer, only create player pc when there is at least one publisher track
sgfn
approved these changes
Feb 24, 2025
Comment on lines
+3
to
+4
| import_deps: [:phoenix], | ||
| plugins: [Phoenix.LiveView.HTMLFormatter], |
Comment on lines
+264
to
+267
| <div class="w-full flex flex-col gap-4"> | ||
| <div | ||
| id="lex-media-devices-wrapper" | ||
| phx-update="ignore" |
There was a problem hiding this comment.
I think we've reached the point where it would be beneficial to move the inline HEEx to its own file and use embed_templates/1
But we can postpone this after the demo is done
lib/live_ex_webrtc/publisher.ex
Outdated
| <input | ||
| type="text" | ||
| id="lex-fps" | ||
| value="24" |
There was a problem hiding this comment.
Just for the time being?
Suggested change
| value="24" | |
| value="30" |
|
Splendid job, thank you 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.