Spawn recorder inside publisher #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t as it resets without a form
…ams_info timer, only create player pc when there is at least one publisher track
sgfn
requested changes
Feb 24, 2025
lib/live_ex_webrtc/publisher.ex
Outdated
Comment on lines
245
to
246
| # Check the "Record stream?" checkbox by default if recordings are allowed | ||
| record? = publisher.recordings? != nil |
There was a problem hiding this comment.
It's a boolean, right?
Suggested change
| # Check the "Record stream?" checkbox by default if recordings are allowed | |
| record? = publisher.recordings? != nil | |
| # Check the "Record stream?" checkbox by default if recordings are allowed | |
| record? = publisher.recordings? == true |
lib/live_ex_webrtc/publisher.ex
Outdated
Comment on lines
661
to
662
| {:ok, recorder} = Recorder.start_link() | ||
| recorder |
There was a problem hiding this comment.
We need to be able to pass arguments to the spawned Recorder instance. Otherwise, there's no way to configure e.g. uploads to S3
mickel8
force-pushed
the
rec-checkbox
branch
from
67caa46 to
ecc14a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Recorder to be spawned by Publisher. This way user doesn't have to care about spawning Recorder.
I also: