Restyle publisher #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgfn
reviewed
Mar 3, 2025
lib/live_ex_webrtc/publisher.ex
Outdated
Comment on lines
411
to
429
| <div class="flex text-sm gap-4"> | ||
| <div class="flex items-center gap-2"> | ||
| <label for="lex-bitrate">Max Bitrate (kbps)</label> | ||
| <input | ||
| type="text" | ||
| id="lex-bitrate" | ||
| value="1500" | ||
| class="rounded-lg disabled:text-gray-400 disabled:border-gray-400 focus:border-brand focus:outline-none focus:ring-0" | ||
| /> | ||
| </div> | ||
| <%= if @publisher.simulcast_supported? do %> | ||
| <div class="flex gap-2.5 items-center text-sm"> | ||
| <label for="lex-simulcast">Simulcast</label> | ||
| <input type="checkbox" id="lex-simulcast" class="rounded-full" /> | ||
| </div> | ||
| <% else %> | ||
| <div class="flex gap-2.5 items-center"> | ||
| <label for="lex-record-stream">Record stream</label> | ||
| <input type="checkbox" class="rounded-full bg-gray-300" disabled /> | ||
| <div class="flex flex-col gap-2 text-sm"> | ||
| <div class="flex gap-2.5 items-center"> | ||
| <label for="lex-simulcast">Simulcast</label> |
There was a problem hiding this comment.
Technically speaking, max bitrate and simulcast should be under "video settings" as well
However, currently the implementation for the "simulcast" checkbox behaves differently than the rest of the settings, as it gets applied immediately without pressing the "apply" button.
We'll change it later -- for now, let's leave everything as-is
sgfn
reviewed
Mar 6, 2025
sgfn
approved these changes
Mar 6, 2025
| @@ -326,7 +326,7 @@ defmodule LiveExWebRTC.Publisher do | |||
| <div class="divide-y divide-indigo-200 flex flex-col items-stretch *:p-4"> | |||
| <div class="flex justify-between items-center"> | |||
| <label for="lex-audio-bitrate">Audio bitrate (kbps):</label> | |||
| <p id="lext-audio-bitrate">0</p> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, check -> elixir-webrtc/glitchtv-demo#6