Support transactions, better listener names in config #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions are now possible; by changing the config a single broker is now enough. The listener names in the broker config can be anything. What most people do (use the protocol name) is very confusing. Instead, we use the role of the listener.
erikvanoosten
force-pushed
the
support-tx
branch
from
a4f16c9 to
582b3e5
Compare
gaeljw
approved these changes
Apr 20, 2025
|
LGTM. I'll let you merge and release :) |
|
@erikvanoosten , FYI I think this repo used to align its version on the Kafka server one and only increase the 4th number to publish changes if the Kafka version hasn't changed in the meantime. It could have been a 4.0.0.1 rather than 4.0.1. I guess that's really not a big deal though. IMHO, we should keep the alignment on the major.minor though. Easier for users to track. |
|
Ah, I didn't know that. I'll keep it in mind for the next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions are now possible; by changing the config a single broker is now enough.
The listener names in the broker config can be anything. What most people do (use the protocol name) is very confusing. Instead, we use the role of the listener.