Skip to content

Commit 71233f1

Browse files
Merge pull request #570 from toddjordan/upgrade-ember
Upgrade ember to 2.18
2 parents 6c939b8 + ddc5472 commit 71233f1

File tree

22 files changed

+355
-382
lines changed

22 files changed

+355
-382
lines changed

.eslintrc.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,15 @@ module.exports = {
3838
browser: false,
3939
node: true
4040
}
41+
},
42+
43+
// test files
44+
{
45+
files: ['tests/**/*.js'],
46+
excludedFiles: ['tests/dummy/**/*.js'],
47+
env: {
48+
embertest: true
49+
}
4150
}
4251
]
4352
};

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ terraform.tfstate.backup
1717
/bower_components
1818

1919
# misc
20+
/.projectile
2021
/.sass-cache
2122
/connect.lock
2223
/coverage/*

.travis.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ addons:
1212
cache:
1313
yarn: true
1414

15+
env:
16+
global:
17+
# See https://git.io/vdao3 for details.
18+
- JOBS=1
19+
1520
before_install:
1621
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.0.1
1722
- export PATH=$HOME/.yarn/bin:$PATH

app/components/search-input/dropdown-result.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export default Component.extend({
2222
const { groupName, groupPosition } = this.getProperties('groupName', 'groupPosition');
2323
return groupPosition === 0? groupName : '';
2424
}),
25-
isSecondary: gt('groupPosition', 0),
25+
isSecondary: gt('groupPosition', 0)
26+
2627

2728
});

app/controllers/project-version.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Controller from '@ember/controller';
22
import { computed } from '@ember/object';
3-
import { alias } from '@ember/object/computed';
3+
import { alias, readOnly } from '@ember/object/computed';
44
import { A } from '@ember/array';
55
import { inject as service } from '@ember/service';
66
import values from 'npm:lodash.values';
@@ -16,7 +16,7 @@ export default Controller.extend({
1616

1717
project: service(),
1818

19-
showPrivateClasses: computed.alias('filterData.sideNav.showPrivate'),
19+
showPrivateClasses: alias('filterData.sideNav.showPrivate'),
2020

2121
classesIDs: computed('model', function() {
2222
return this.getRelationshipIDs('classes');
@@ -91,5 +91,5 @@ export default Controller.extend({
9191
return this.get('projectVersions').filter(pV => pV.id === this.get('model.version'))[0];
9292
}),
9393

94-
activeProject: computed.readOnly('model.project.id')
94+
activeProject: readOnly('model.project.id')
9595
});

app/controllers/project-version/modules/module.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { alias } from '@ember/object/computed';
12
import { computed } from '@ember/object';
23
import { inject as service } from '@ember/service';
34
import ClassController from '../classes/class';
@@ -6,7 +7,7 @@ import union from 'npm:lodash.union';
67

78
export default ClassController.extend({
89
filterData: service(),
9-
showPrivateClasses: computed.alias('filterData.sideNav.showPrivate'),
10+
showPrivateClasses: alias('filterData.sideNav.showPrivate'),
1011

1112
submodules: computed('model', function() {
1213
return Object.keys(this.get('model.submodules'));

app/mixins/parent-name.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1+
import { readOnly } from '@ember/object/computed';
12
import { computed } from '@ember/object';
23
import Mixin from '@ember/object/mixin';
34
import { inject as service } from '@ember/service';
45

56
export default Mixin.create({
67
router: service('-routing'),
78

8-
routeName: computed.readOnly('router.currentRouteName'),
9+
routeName: readOnly('router.currentRouteName'),
910
parentName: computed('routeName', function() {
1011
const routeName = this.get('routeName');
1112
const routes = routeName.split('.');

app/styles/base/_buttons.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#{$all-button-inputs},
1+
#{$all-buttons},
22
button {
33
appearance: none;;
44
-webkit-font-smoothing: antialiased;

app/styles/components/_article.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ article {
66
}
77

88
.edit-page {
9-
@include size(24px 18px);
9+
@include size(24px, 18px);
1010
color: $brown;
1111
display: inline-block;
1212
float: right;

app/styles/components/_highlight.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@
102102

103103
.ribbon {
104104
@include position(absolute, 0.33em 0px null null);
105-
@include size(52px 20px);
105+
@include size(52px, 20px);
106106
background: 0 0 no-repeat;
107107
background-size: 52px 20px;
108108
z-index: 9;

bower.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"name": "ember-api-docs",
33
"dependencies": {
44
"bitters": "^1.5.0",
5-
"bourbon": "^4.2.7",
65
"highlightjs": "^9.8.0",
76
"neat": "^1.8.0",
87
"remarkable": "^1.7.1"

config/environment.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
/* eslint-env node */
2+
'use strict';
3+
24
module.exports = function(environment) {
35
let ALGOLIA_APP_ID = process.env.ALGOLIA_APP_ID || 'Y1OMR4C7MF';
46
let ALGOLIA_API_KEY = process.env.ALGOLIA_API_KEY || 'c35425b69b31be1bb4786f0a72146306';
@@ -70,6 +72,7 @@ module.exports = function(environment) {
7072
defaultBreakpoints: ['mobile', 'desktop']
7173
};
7274

75+
ENV.APP.autoboot = false;
7376
}
7477

7578
ENV.contentSecurityPolicy = {

config/targets.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
module.exports = {
2+
browsers: [
3+
'ie 11',
4+
'last 1 Chrome versions',
5+
'last 1 Firefox versions',
6+
'last 1 Safari versions'
7+
]
8+
};

ember-cli-build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-env node */
21
'use strict';
32

43
const EmberApp = require('ember-cli/lib/broccoli/ember-app');

package.json

Lines changed: 33 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"name": "ember-api-docs",
33
"version": "0.1.0",
4+
"private": true,
45
"description": "Small description for ember-api-docs goes here",
56
"license": "MIT",
67
"author": "Ember Learning Team and contributors",
@@ -14,60 +15,47 @@
1415
"scripts": {
1516
"build": "ember build",
1617
"postinstall": "npm rebuild node-sass",
17-
"start": "ember server",
18+
"lint:js": "eslint ./*.js app config lib server tests",
19+
"start": "ember serve",
1820
"test": "node run-tests.js"
1921
},
20-
"dependencies": {
21-
"algoliasearch": "^3.24.3",
22-
"ember-cli-browserstack": "^0.0.6",
23-
"ember-rfc176-data": "^0.3.1",
24-
"lodash.groupby": "^4.6.0",
25-
"lodash.last": "^3.0.0",
26-
"lodash.sortby": "^4.7.0",
27-
"lodash.union": "^4.6.0",
28-
"lodash.uniq": "^4.5.0",
29-
"lodash.values": "^4.3.0",
30-
"sanitize-html": "^1.18.2",
31-
"semver-compare": "^1.0.0",
32-
"testem": "^2.2.1"
33-
},
3422
"devDependencies": {
3523
"broccoli-asset-rev": "^2.5.0",
3624
"broccoli-funnel": "^2.0.1",
3725
"broccoli-merge-trees": "^2.0.0",
38-
"ember-a11y-testing": "^0.4.3",
39-
"ember-algolia": "^0.0.6",
40-
"ember-anchor": "~0.1.8",
26+
"ember-a11y-testing": "^0.5.4",
27+
"ember-algolia": "0.0.10",
28+
"ember-anchor": "~0.2.0",
4129
"ember-browserify": "^1.2.0",
42-
"ember-cli": "^2.14.1",
30+
"ember-cli": "~2.18.1",
4331
"ember-cli-app-version": "^3.0.0",
4432
"ember-cli-autoprefixer": "^0.7.0",
4533
"ember-cli-babel": "^6.6.0",
46-
"ember-cli-bourbon": "^1.2.2",
34+
"ember-cli-bourbon": "^2.0.1",
4735
"ember-cli-clipboard": "0.8.1",
4836
"ember-cli-content-security-policy": "^0.6.1",
4937
"ember-cli-dependency-checker": "^2.0.1",
5038
"ember-cli-deploy": "^1.0.1",
5139
"ember-cli-deploy-build": "^1.1.0",
5240
"ember-cli-deploy-gzip": "^1.0.0",
53-
"ember-cli-document-title": "^0.3.3",
54-
"ember-cli-eslint": "^4.2.0",
41+
"ember-cli-document-title": "^0.4.0",
42+
"ember-cli-eslint": "^4.2.1",
5543
"ember-cli-fastboot": "^1.0.1",
5644
"ember-cli-htmlbars": "^2.0.2",
57-
"ember-cli-htmlbars-inline-precompile": "^0.4.3",
45+
"ember-cli-htmlbars-inline-precompile": "^1.0.0",
5846
"ember-cli-inject-live-reload": "^1.7.0",
5947
"ember-cli-meta-tags": "^5.0.0",
6048
"ember-cli-qunit": "^4.3.0",
6149
"ember-cli-sass": "^8.0.1",
62-
"ember-cli-shims": "^1.1.0",
50+
"ember-cli-shims": "^1.2.0",
6351
"ember-cli-template-lint": "^0.7.1",
64-
"ember-cli-uglify": "^1.2.0",
52+
"ember-cli-uglify": "^2.0.0",
6553
"ember-composable-helpers": "^2.0.3",
6654
"ember-concurrency": "0.8.18",
67-
"ember-data": "^2.14.8",
68-
"ember-data-fastboot": "0.1.0",
69-
"ember-disable-proxy-controllers": "^1.0.1",
70-
"ember-exam": "^0.7.0",
55+
"ember-data": "~2.18.0",
56+
"ember-data-fastboot": "^0.1.2",
57+
"ember-disable-proxy-controllers": "^1.0.2",
58+
"ember-exam": "^1.0.0",
7159
"ember-export-application-global": "^2.0.0",
7260
"ember-fetch": "^3.2.9",
7361
"ember-inflector": "^2.0.1",
@@ -79,7 +67,7 @@
7967
"ember-power-select": "^1.9.2",
8068
"ember-resolver": "^4.3.0",
8169
"ember-route-action-helper": "^2.0.5",
82-
"ember-source": "^2.14.1",
70+
"ember-source": "~2.18.0",
8371
"ember-styleguide": "^2.3.1",
8472
"ember-svg-jar": "^1.2.2",
8573
"ember-test-selectors": "^0.3.6",
@@ -99,7 +87,21 @@
9987
"node": ">= 8",
10088
"npm": "5"
10189
},
102-
"private": true,
90+
"dependencies": {
91+
"algoliasearch": "^3.24.3",
92+
"bourbon": "5.1.0",
93+
"ember-cli-browserstack": "^0.0.6",
94+
"ember-rfc176-data": "^0.3.1",
95+
"lodash.groupby": "^4.6.0",
96+
"lodash.last": "^3.0.0",
97+
"lodash.sortby": "^4.7.0",
98+
"lodash.union": "^4.6.0",
99+
"lodash.uniq": "^4.5.0",
100+
"lodash.values": "^4.3.0",
101+
"sanitize-html": "^1.18.2",
102+
"semver-compare": "^1.0.0",
103+
"testem": "^2.2.1"
104+
},
103105
"cacheDirectories": [
104106
"bower_components",
105107
"node_modules"

public/crossdomain.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/acceptance/anchors-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import moduleForAcceptance from 'ember-api-docs/tests/helpers/module-for-acceptance';
22
import { test } from 'qunit';
3-
import { visit, click, findAll} from 'ember-native-dom-helpers';
3+
import { visit, click, findAll } from 'ember-native-dom-helpers';
44

55
moduleForAcceptance('Acceptance | Creating Anchors');
66

tests/acceptance/items-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import moduleForAcceptance from 'ember-api-docs/tests/helpers/module-for-acceptance';
22
import { test } from 'qunit';
3-
import { visit, click, findAll} from 'ember-native-dom-helpers';
3+
import { visit, click, findAll } from 'ember-native-dom-helpers';
44

55
moduleForAcceptance('Acceptance | ItemRoutes');
66

tests/helpers/resolver.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

tests/helpers/start-app.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ registerPowerSelectHelpers();
99

1010
export default function startApp(attrs) {
1111
let attributes = merge({}, config.APP);
12+
attributes.autoboot = true;
1213
attributes = merge(attributes, attrs); // use defaults, but you can override;
1314

1415
return run(() => {

tests/test-helper.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import resolver from './helpers/resolver';
2-
import { setResolver } from '@ember/test-helpers';
1+
import Application from '../app';
2+
import config from '../config/environment';
3+
import { setApplication } from '@ember/test-helpers';
4+
import { start } from 'ember-qunit';
35
import loadEmberExam from 'ember-exam/test-support/load';
4-
import { start } from 'ember-cli-qunit';
5-
6-
setResolver(resolver);
76
loadEmberExam();
7+
setApplication(Application.create(config.APP));
88
start();

0 commit comments

Comments
 (0)