Upgrade ember to 2.18 #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
toddjordan
commented
Oct 26, 2018
config/targets.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| module.exports = { | |||
| browsers: [ | |||
| 'ie 9', | |||
There was a problem hiding this comment.
Should we support IE 9?
There was a problem hiding this comment.
No, let's do IE11 & above. The same as ember 3.x support
sivakumar-kailasam
previously requested changes
Oct 26, 2018
MODULE_REPORT.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| ## Module Report | |||
There was a problem hiding this comment.
This is an autogenerated file. We don't need this
config/targets.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| module.exports = { | |||
| browsers: [ | |||
| 'ie 9', | |||
There was a problem hiding this comment.
No, let's do IE11 & above. The same as ember 3.x support
toddjordan
force-pushed
the
upgrade-ember
branch
from
d6e9d49 to
035a2c4
Compare
toddjordan
force-pushed
the
upgrade-ember
branch
from
cc8b4ee to
ddc5472
Compare
toddjordan
dismissed
sivakumar-kailasam’s stale review
Deleted generated codemod markdown and changed ie target to 11
|
@sivakumar-kailasam the deployed review app looks pretty good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an incremental approach to getting api docs up to the latest ember. I'm using pr #501 as a resource, as it grew and diverged a bit from the latest api-docs because we let it live a bit too long in pending. Ultimate goal is the same.