[WIP] 3.x upgrade #501
Closed
[WIP] 3.x upgrade #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sivakumar-kailasam
commented
Apr 23, 2018
sivakumar-kailasam
commented
- Ran ember-cli-update with codemods
- Simplified test assertions with qunit-dom
- Introduced prettier setup that'll work as code is git staged on local
- Replaced hardcoded config value with actual reference to config.
Merged
|
First off thanks for this (its a lot!). Tried to resolve conflicts on but finding it hard, partially because of its age. I also think its trying to do a bit too much for one pr (prettier, replacing libs with custom versions, etc), which I'd like to handle more incrementally. I'd like to take a bit more incremental approach. I've started the process in PR #570 |
|
No worries, I was a bit ambitious when I started on this 😅. Your approach is much more realistic. |
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.