Merge pull request #777 from rajakvk/rk-775-fix-linting-error-2

Fix linting error (#775)

Author: locks

app/components/api-index-filter.js

@@ -1,4 +1,4 @@
-/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
+/* eslint-disable ember/no-computed-properties-in-native-classes */
 import { classNames } from '@ember-decorators/component';
 import { computed } from '@ember/object';
 import Component from '@ember/component';
@@ -26,19 +26,17 @@ export default class ApiIndexFilter extends Component {
 
   filterItems(itemType) {
     let items =
-      this.get(`model.${itemType}`) === undefined
-        ? []
-        : this.get(`model.${itemType}`);
-    if (!this.get('filterData.showInherited')) {
+      this.model[itemType] === undefined ? [] : this.model[`${itemType}`];
+    if (!this.filterData.showInherited) {
       items = items.filter((item) => item.inherited !== true);
     }
-    if (!this.get('filterData.showProtected')) {
+    if (!this.filterData.showProtected) {
       items = items.filter((item) => item.access !== 'protected');
     }
-    if (!this.get('filterData.showPrivate')) {
+    if (!this.filterData.showPrivate) {
       items = items.filter((item) => item.access !== 'private');
     }
-    if (!this.get('filterData.showDeprecated')) {
+    if (!this.filterData.showDeprecated) {
       items = items.filter((item) => item.deprecated !== true);
     }
 
@@ -91,8 +89,8 @@ export default class ApiIndexFilter extends Component {
    * @method findMostLocal
    */
   findMostLocal(currentItem, nextItem) {
-    let currentScope = this.get('model.file');
-    let parentClassScope = this.get('model.parentClass.file');
+    let currentScope = this.model.file;
+    let parentClassScope = this.model.get('parentClass').get('file');
     if (currentScope === currentItem.file) {
       // if the item belongs to the class, keep it
       return currentItem;

app/components/api-index.js

@@ -1,4 +1,4 @@
-/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
+/* eslint-disable ember/no-computed-properties-in-native-classes */
 import { computed } from '@ember/object';
 import Component from '@ember/component';
 
@@ -9,21 +9,21 @@ export default class ApiIndex extends Component {
       {
         title: 'Methods',
         tab: 'methods',
-        items: this.get('itemData.methods'),
+        items: this.itemData.methods,
         class: 'spec-method-list',
         routeSuffix: '.methods.method',
       },
       {
         title: 'Properties',
         tab: 'properties',
-        items: this.get('itemData.properties'),
+        items: this.itemData.properties,
         class: 'spec-property-list',
         routeSuffix: '.properties.property',
       },
       {
         title: 'Events',
         tab: 'events',
-        items: this.get('itemData.events'),
+        items: this.itemData.events,
         class: 'spec-event-list',
         routeSuffix: '.events.event',
       },

tests/integration/components/api-index-filter-test.js

@@ -22,9 +22,9 @@ module('Integration | Component | api index filter', function (hooks) {
     },
     name: 'hai',
     file: 'my-class',
-    parentClass: {
+    parentClass: EmberObject.create({
       file: 'my-class',
-    },
+    }),
     methods: [
       {
         name: 'doSomething',