Fix linting error (#775) #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jenweber
reviewed
Oct 21, 2021
app/components/api-index-filter.js
Outdated
| @@ -26,19 +25,19 @@ export default class ApiIndexFilter extends Component { | |||
|
|
|||
| filterItems(itemType) { | |||
| let items = | |||
| this.get(`model.${itemType}`) === undefined | |||
| this.model[`${itemType}`] === undefined | |||
There was a problem hiding this comment.
I think we can simplify this now:
Suggested change
| this.model[`${itemType}`] === undefined | |
| this.model[itemType] === undefined |
I think maybe the linter is complaining about formatting here too. Maybe this should be on the same line as let items = now that it is shorter.
jenweber
reviewed
Oct 21, 2021
jenweber
reviewed
Oct 21, 2021
locks
requested changes
Oct 28, 2021
app/components/api-index-filter.js
Outdated
Comment on lines
92
to
93
| let currentScope = this.model.file; | ||
| let parentClassScope = this.model.parentClass.file; |
There was a problem hiding this comment.
Tests are failing because model is an Ember Data model and file seems to be a relationship? Since Ember Data models are proxy objects, you still need to use get to get relationship values:
Suggested change
| let currentScope = this.model.file; | |
| let parentClassScope = this.model.parentClass.file; | |
| let currentScope = this.model.file; | |
| let parentClassScope = this.model.get('parentClass').file; |
rajakvk
force-pushed
the
rk-775-fix-linting-error-2
branch
from
6ba5d2f to
f67b5e0
Compare
locks
approved these changes
Nov 4, 2021
locks
force-pushed
the
rk-775-fix-linting-error-2
branch
from
c682222 to
885f302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes item-1 at #775