Skip to content

Modules refactor #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2017
Merged

Modules refactor #308

merged 5 commits into from
Jul 28, 2017

Conversation

acorncom
Copy link
Member

@acorncom acorncom commented Jul 28, 2017 •
edited
Loading

No description provided.

@locks locks temporarily deployed to ember-api-docs-staging-pr-308 July 28, 2017 02:19 Inactive
@acorncom
Copy link
Member Author

Applies the https://github.com/ember-cli/ember-modules-codemod Do we want to apply this or wait until 2.16 lands? /cc @locks

I'm inclined to use it as we can use this app to help teach folks about how to make the change ...

@sivakumar-kailasam
Copy link
Member

@acorncom there's a eslint config to ensure that direct ember imports would cause eslint failures. We should probably add it along with this PR. @Turbo87 might be aware of it.

Turbo87
Turbo87 approved these changes Jul 28, 2017
View reviewed changes
Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acorncom nice work! I think we should merge it now instead of waiting.

@Turbo87
Copy link
Contributor

Turbo87 commented Jul 28, 2017

there's a eslint config to ensure that direct ember imports would cause eslint failures

the rule only warns about usage of the old shims from ember-cli-shims but it does not warn about import Ember from 'ember' yet because there are still legitimate use cases for that (e.g. Ember.testing).

We should probably add it along with this PR

seems like a somewhat unrelated change and should be done in a separate PR to not block this one

@acorncom
Copy link
Member Author

@Turbo87 I pushed a few buttons, it's really easy to do 😀 Thanks for all your work on that ...

@locks locks merged commit 7943dba into master Jul 28, 2017
@locks
Copy link
Contributor

locks commented Jul 28, 2017

Oops, I also just pushed a couple of buttons. Nice work!

@locks locks deleted the modules-refactor branch July 28, 2017 15:59
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
@dependabot
Bump walk-sync from 0.3.3 to 1.0.0 (ember-learn#308)
a40823f 
Bumps [walk-sync](https://github.com/joliss/node-walk-sync) from 0.3.3 to 1.0.0.
- [Release notes](https://github.com/joliss/node-walk-sync/releases)
- [Changelog](https://github.com/joliss/node-walk-sync/blob/master/CHANGELOG.md)
- [Commits](joliss/node-walk-sync@v0.3.3...v1.0.0)

Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

@sivakumar-kailasam sivakumar-kailasam sivakumar-kailasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acorncom @sivakumar-kailasam @Turbo87 @locks