Skip to content

[WIP] Split out module name from access (DOM) #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2017
Merged

[WIP] Split out module name from access (DOM) #312

merged 4 commits into from
Aug 31, 2017

Conversation

mschinis
Copy link
Contributor

@mschinis mschinis commented Jul 30, 2017

This splits out the module name header from the access span.
It will help getting rid of the "public", "private" from the algolia search results.

This should be the final change needed before we can get the search back up.

I'll re-run the docsearch scraper once again once this is on staging, but we should be good to go

@locks locks temporarily deployed to ember-api-docs-staging-pr-312 July 30, 2017 23:40 Inactive
@mschinis mschinis changed the title [RFC] Split out module name from access (DOM) [WIP] Split out module name from access (DOM) Jul 31, 2017
@mschinis
Copy link
Contributor Author

mschinis commented Jul 31, 2017

@locks locks temporarily deployed to ember-api-docs-staging-pr-312 August 1, 2017 06:38 Inactive
@locks locks temporarily deployed to ember-api-docs-staging-pr-312 August 10, 2017 02:22 Inactive
@locks locks temporarily deployed to ember-api-docs-staging-pr-312 August 16, 2017 20:57 Inactive
@mschinis
Copy link
Contributor Author

@toddjordan Can we merge this in?

@toddjordan toddjordan merged commit 80d9c6f into ember-learn:master Aug 31, 2017
@mschinis mschinis deleted the feat/split-out-module-name branch September 1, 2017 10:13
lifeart pushed a commit to lifeart/ember-api-docs that referenced this pull request Apr 18, 2018
* feat(class): Split out module name from access

* style(class): Fix method access styling

* feat(application): Adds class on API link
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants