Skip to content

[WIP] Rename modules to packages #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Jul 31, 2017

WIP

Resolves: #285

amyrlam added 5 commits July 30, 2017 23:47
Rename submodules to subpackages

Add new route for /packages
…ith a transitionTo packages. Failed so went with renaming.

Not quite sure what the issue here is yet, so going to explore the tests.
@sivakumar-kailasam sivakumar-kailasam changed the title Rename modules to packages [WIP] Rename modules to packages Jul 31, 2017
@amyrlam
Copy link
Member Author

amyrlam commented Jul 31, 2017

@locks here is my WIP to help with async help. if you or others have any ideas on how to further debug, please lmk!

  • package contents (subpackages?) don't appear at all

IS:
image

master:
image

  • have 7 test failures, most with the TypeError: Cannot read property 'split' of undefined error, but lost on how to debug

//

  • initially wanted to just add a redirect modules to packages, ended up not quite working, so went for the full thing
  • as is, was a little unsure of how to handle the transitionTo since wasn't a straightforward beforeModel
  • removed headless chrome for debugging purposes only
  • just saw the merge conflicts, can address later
  • git history here was more for my own purposes, would be cleaned up ofc

@locks locks temporarily deployed to ember-api-docs-staging-pr-313 July 31, 2017 08:39 Inactive
@locks locks self-assigned this Jul 31, 2017
@jenweber
Copy link
Contributor

jenweber commented Aug 1, 2017

I think you need a custom serializer to map things in the payload named "module" or variations of it to the appropriate fields in Ember Data where it's named package.

screen shot 2017-07-31 at 10 51 35 pm

@amyrlam
Copy link
Member Author

amyrlam commented Aug 2, 2017

new WIP PR: #315

@amyrlam amyrlam closed this Aug 2, 2017
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants