Skip to content

[BUGFIX]Fix broken method link #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akashdsouza
Copy link
Contributor

@akashdsouza akashdsouza commented Aug 5, 2017

@locks locks temporarily deployed to ember-api-docs-staging-pr-319 August 5, 2017 11:55 Inactive
@sivakumar-kailasam
Copy link
Member

@akashdsouza thanks for the PR, the review app is deployed at https://ember-api-docs-staging-pr-319.herokuapp.com/api/ember/2.14/namespaces/Ember.computed/methods?anchor= .

The page used to scroll to the methods tab in view which was the previous behavior until commit 3736291. This can be seen at https://ember-api-docs-staging.herokuapp.com/api/ember/2.14/classes/Ember.Component/methods?anchor=. Can you please try addressing it as a part of this PR?

@locks locks temporarily deployed to ember-api-docs-staging-pr-319 August 7, 2017 09:27 Inactive
@akashdsouza
Copy link
Contributor Author

akashdsouza commented Aug 7, 2017

@MartinMalinda, as discussed on slack, I have added manual scrolling. If this looks ok, I can add the same to /methods under classes and modules(perhaps in a mixin?).
I have also been trying to add test cases for the same. However, when didTransition action fires, the page is still in loading state. I'm not sure what's causing this.

@akashdsouza
Copy link
Contributor Author

Since this has become stale for some time, I cherry-picked the autoscroll issue fix commit and created a separate PR( #321 ). This way, we can fix the broken links immediately.

@toddjordan toddjordan merged commit 73c5701 into ember-learn:master Aug 15, 2017
@akashdsouza akashdsouza deleted the bugfix_broken_method_link branch August 16, 2017 07:15
MartinMalinda pushed a commit to MartinMalinda/ember-api-docs that referenced this pull request Aug 16, 2017
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants