Mobile friendlier header, footer, and code blocks #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar-kailasam
requested changes
Aug 6, 2017
|
@jenweber let me know if it was because of page layout in which case this looks good to merge. |
|
I'll change the breakpoints to match. Good catch. |
|
@sivakumar-kailasam I have updated the header/footer breakpoints to match the rest of the website. It still needs another pair of eyes just to be sure. I have also replaced any stray breakpoints to be the variables in If it all looks right for you too, I think this is good to go. |
sivakumar-kailasam
approved these changes
Aug 13, 2017
|
Looks great now @jenweber. The header being fixed must've been a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317 and maybe #274
Sidebar bug: I brought in the media query breaks just a bit, to align the sidebar behavior with the container. This means it jumps into mobile arrangement sooner.
Responsive header/footer: The main problem was that all the responsive CSS ported over from the main site wasn't being applied because that class was was not included in the html.
Coderay block separating from line numbers: just a global-ish css rule on tables that didn't make sense.
Coderay block selection: in the more global CSS was a
z-index: -1applied to table layouts, which had an unexpected effect on code blocks. Setting the z index back to normal for coderay tables fixes the cursor problem. TBD whether code can be copied & pasted in mobile.